Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cometbft and use latest iavl & wasmd & wasmvm #88

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Dec 26, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Updated environment variable for libwasmvm to version v2.1.4.
  • Bug Fixes

    • Updated dependency versions for improved stability and performance:
      • github.com/CosmWasm/wasmd to v0.53.2.
      • github.com/CosmWasm/wasmvm/v2 to v2.1.4.
  • Chores

    • Removed outdated dependency replacement for github.com/cosmos/iavl.

@beer-1 beer-1 self-assigned this Dec 26, 2024
@beer-1 beer-1 requested a review from a team as a code owner December 26, 2024 07:58
Copy link

coderabbitai bot commented Dec 26, 2024

Walkthrough

This pull request involves updating dependency versions in both the Dockerfile and go.mod file. The changes primarily focus on upgrading the versions of libwasmvm and related dependencies, specifically updating LIBWASMVM_VERSION from v2.1.3 to v2.1.4 and adjusting corresponding dependency versions in the go.mod file. The updates include modifications to CosmWasm-related libraries and a change in the CometBFT replacement version.

Changes

File Changes
Dockerfile - Updated LIBWASMVM_VERSION from v2.1.3 to v2.1.4
go.mod - Updated github.com/CosmWasm/wasmd from v0.53.0 to v0.53.2
- Updated github.com/CosmWasm/wasmvm/v2 from v2.1.3 to v2.1.4
- Updated CometBFT replacement version
- Removed github.com/cosmos/iavl replacement

Poem

🐰 Hop, hop, dependencies dance!
Versions bump with a rabbit's glance
WasmVM leaps to version new
CometBFT joins the upgrade crew
Code evolves with each small change
Libraries now freshly arranged! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0519b7e and c62c394.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • Dockerfile (1 hunks)
  • go.mod (2 hunks)
🔇 Additional comments (3)
Dockerfile (1)

5-5: LGTM! Consider updating hash verification.

The version update is consistent with the changes in go.mod. However, the commented hash verification lines should be updated with the correct hashes for v2.1.4 to ensure the integrity of the downloaded libraries.

Run the following script to fetch and verify the hash values for v2.1.4:

✅ Verification successful

Let me try a different approach to verify the hashes.


Let me try one more verification to get the official hashes from the release page.


Let me try to fetch the checksums file specifically.


Update hash verification with new checksums for v2.1.4

The commented hash verification lines in the Dockerfile should be updated with the following correct hashes for v2.1.4:

  • For aarch64: 090b97641157fae1ae45e7ed368a1a8c091f3fef67958d3bc7c2fa7e7c54b6b4
  • For x86_64: a4a3d09b36fabb65b119d5ba23442c23694401fcbee4451fe6b7e22e325a4bac

Update the commented lines to:

RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep 090b97641157fae1ae45e7ed368a1a8c091f3fef67958d3bc7c2fa7e7c54b6b4
RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep a4a3d09b36fabb65b119d5ba23442c23694401fcbee4451fe6b7e22e325a4bac
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Fetch and display SHA256 hashes for libwasmvm v2.1.4 libraries

echo "Fetching hashes for libwasmvm v2.1.4 libraries..."

# Download and compute hashes for both architectures
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/libwasmvm_muslc.x86_64.a" | sha256sum
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/libwasmvm_muslc.aarch64.a" | sha256sum

# Note: Compare these hashes with the official release page
echo -e "\nVerify these hashes against: https://github.com/CosmWasm/wasmvm/releases/tag/v2.1.4"

Length of output: 708


Script:

#!/bin/bash
# Let's check the Dockerfile to see if there are any commented hash verification lines
cat Dockerfile

Length of output: 2163


Script:

#!/bin/bash
# Use GitHub CLI to fetch the release information
gh release view v2.1.4 --repo CosmWasm/wasmvm

Length of output: 510


Script:

#!/bin/bash
# Download and display the checksums file
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/checksums.txt"

Length of output: 613

go.mod (2)

21-22: LGTM! Version updates are consistent.

The updates to wasmd and wasmvm versions are aligned with the PR objectives. The helpful comment about updating the Dockerfile ensures synchronization between the two files.


282-282: Verify the commit hash for cometbft replacement.

The cometbft replacement points to a specific commit. Ensure this commit is stable and contains the intended changes.

Run the following script to verify the commit:


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 merged commit 3d3584c into main Dec 27, 2024
7 checks passed
@beer-1 beer-1 deleted the bump/deps branch December 27, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant